-
Notifications
You must be signed in to change notification settings - Fork 725
bugfix new block reward payment and verification #2772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix new block reward payment and verification #2772
Conversation
7dacfcd to
3b5b9e1
Compare
3b5b9e1 to
a50ba7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straightforward adjustment.
uTACK a50ba7e
See no issue in using the height from the caller because then will get more accurate at the time.
DeanSparrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK a50ba7e
add testnet checkpoints - 925056 (lastblock before v5.5) - 925057 (firstblock after v5.5) - 925063 (added to circumvent failure on last (default 6) blocks verification due to PIVX-Project#2772) add -rewindblockindextolastcheckpoint option add RewindBlockIndexToLastCheckpoint to init Step 7: load block chain modify RewindBlockIndexToLastCheckpoint - check if rewind is needed - use targetHeight instead of targetHash - add progress indicator on rewind - clearWitnessCaches - zap all transactions from wallet - rescan wallet transactions - restore wallet transaction metadata after rescan (unless -zapwallettxes=2) add functional test
Fuzzbawls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK a50ba7e
Github-Pull: PIVX-Project#2772 Rebased-From: a50ba7e
c0f6055 [Consensus] Bump v5.5 activation height for mainnet (Fuzzbawls) 200b908 [Consensus] Set v5.5 activation height for mainnet (Fuzzbawls) dc31cef Add functional test for scantxoutset (PeterL73) b452fb6 Remove commented out code (PeterL73) 3fc2e6b Backport scantxoutset and descriptors from BitCoin Core v0.17.2 (PeterL73) 8f5f52d Remove semicolon and add "verbose" back to vRPCConvertParams. (tecnovert) ba310d1 Test for hex strings and remove stray newline from rpc_named_arguments. (tecnovert) 2b244ba Fix missing help text and add backwards compatibility. (tecnovert) cce6951 rpc: Backport getblock verbosity (tecnovert) fd719a2 add include_delegated to vRPCConvertParams (PeterL73) d285af0 use block height from caller (PeterL73) Pull request description: Backports the following PRs to the `5.5` branch: #2772 #2774 #2779 #2780 #2781 #2784 Top commit has no ACKs. Tree-SHA512: b0858e8ce7a39a1a3399fb2cf3eb4c4e77ecd526d9c8ca38fab0dc1ca6d108c962a581c8e481d8ac584a35b8a88f58d9d887166a35aec8fdfb66e8d57232dfa8
use the requiredMasternodePayment of the new block
in CMasternodeBlockPayees::IsTransactionValid [masternode-payments.cpp]