[GUI] Fix Passing Not Funded logic #2768
Conversation
|
My reading is that (all other conditions equal) now if allocatedAmount + prop->GetAmount() <= getMaxAvailableBudgetAmount() the proposal status is NOT_PASSING while before it was PASSING_NOT_FUNDED. That seems strange to me and might merit a double check. |
Followup to PIVX-Project#2717 which was incorrectly marking proposals as Over Budget instead of Not Passing
Determining if a proposal is over budget requires an accurate count of the number of MNs active on the network. To get this, start the MN update timer on launch as well as when activating the DAO page.
Fuzzbawls
force-pushed
the
2022_gui-prop-status
branch
from
81addf0 to
a450ea2
Compare
|
Here are screenshots to show how this logic change is effective master branch: this PR: Note: I did add an additional commit to start the MN update timer at launch, and when activating the DAO page of the UI. Without that, the cached MN count would only be updated when activating the Settings -> Debug -> Info page or the RPCConsole UI window. |
|
ACK a450ea2 Good check. My reading is that the isPassing variable in the if/else enables the desired logic.. |
3 participants
Followup to #2717 which was incorrectly marking proposals as Over Budget
instead of Not Passing