[GA] Run unit/functional tests on native macOS 11 #2767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeanSparrow
reviewed
Sep 16, 2022
There was a problem hiding this comment.
Please confirm this is not a TYPO?
create_director
Collaborator
Author
There was a problem hiding this comment.
this is indeed not a typo. Boost changed the text of the error message starting in version 1.78. so, to maintain compatibility with earlier and newer versions of Boost, a partial text match is now used. create_director will match the old (create_directory) as well as the new (create_directories) string.
Enable the Unit and Functional testing suites for GA runs on native macOS 10.15.
macOS 10.15 runners have been deprecated, and will cease to be supported on 8/30/2022. actions/runner-images#5583
`fs::create_directories` now has an error message saying `create_directories` instead of `create_directory`. This caused wallet_multiwallet.py to fail. The error message check has been updated to be able accept either string.
Fuzzbawls
force-pushed
the
2022_GA-native-macos-tests
branch
from
4d66c99 to
945724b
Compare
|
utACK c5960bc Reviewed file diffs. Precise specification of pip version to 3.8 and OS version changes make sense. Error reporting change well explained. |
yenachar
approved these changes
Sep 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump our native macOS GA runner to macOS 11 (as 10.15 is now deprecated and will cease to function in December), as well as enable unit and functional tests for our native macOS runner, and fix an issue with Boost 1.78+ compatibility for the multiwallet functional test.
Last commit inspired by bitcoin#24104