[Build][CMake] Use CMake internal instead of custom command for moc #2759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake has an internal function (`qt5_generate_moc`) that can be used to forcibly generate a `.moc` file. Use that instead of the generic `execute_process` function. This fixes an issue on systems (fe, Arch Linux) where Qt's moc binary are placed in a different location than debian based distros.
|
utACK 68dc51d Verified the macro qt5_generate_moc. Its use here not only corrects an issue but is also more readable/cleaner. |
yenachar
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake has an internal function (
qt5_generate_moc) that can be used toforcibly generate a
.mocfile. Use that instead of the genericexecute_processfunction.This fixes an issue on systems (fe, Arch Linux) where Qt's moc binary
are placed in a different location than debian based distros.