Skip to content

QA: Add proper bech32 encoding/decoding utilities to python framework #2747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 1 commit into from
Mar 2, 2022
Merged

QA: Add proper bech32 encoding/decoding utilities to python framework #2747

furszy merged 1 commit into from
Mar 2, 2022

Conversation

@random-zebra
Copy link

@random-zebra random-zebra commented Feb 16, 2022

As per title, completes the rudimentary python implementation introduced in #2733

@random-zebra random-zebra added this to the 6.0.0 milestone Feb 16, 2022
@random-zebra random-zebra self-assigned this Feb 16, 2022
furszy
furszy approved these changes Feb 22, 2022
View reviewed changes
Copy link

@furszy furszy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you had some fun here, utACK 7e04420

For a future work, we can use it to validate the Sapling keys import and export functionalities too.

@furszy furszy merged commit 4e46b14 into PIVX-Project:master Mar 2, 2022
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@furszy furszy furszy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@random-zebra random-zebra

Labels

Tests

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@random-zebra @furszy @Fuzzbawls