Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Feb 14, 2022

Follow-up to #2742.

  1. Notify user if the Deterministic MN initialization failed for a local non-recoverable error.

  2. Moved the startup Masternode activation after the connection manager initialization.
    Without it, as the network module isn't initialized, the MN connectivity check always fails.

  3. Removed an overkill check that was rejecting incoming connections on Masternodes if the node wasn't, tier two wise, synchronized.
    The tier two sync preference for outbound connections can, and will, be achieved differently on a subsequent PR.

@furszy furszy self-assigned this Feb 14, 2022
@furszy furszy force-pushed the 2022_init_dmn_error branch from a864996 to 32edd63 Compare February 15, 2022 20:35
@furszy
Copy link
Author

furszy commented Feb 15, 2022

Added two more fixes that were blocking the completion of the distributed key generation protocol:

  1. Moved the startup Masternode activation after the connection manager initialization.
    Without it, as the network module isn't initialized, the MN connectivity check always fails.

  2. Removed an overkill check that was rejecting incoming connections on Masternodes if the node wasn't, tier two wise, synchronized.
    The tier two sync preference for outbound connections can, and will, be achieved differently on a subsequent PR.

@furszy furszy force-pushed the 2022_init_dmn_error branch from 32edd63 to f48176b Compare February 20, 2022 13:45
@furszy
Copy link
Author

furszy commented Feb 20, 2022

rebased after 2742 merge, ready to go.

@random-zebra random-zebra added this to the 6.0.0 milestone Feb 21, 2022
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f48176b

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f48176b

@furszy furszy merged commit fccfe2c into PIVX-Project:master Feb 28, 2022
@furszy furszy deleted the 2022_init_dmn_error branch August 11, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants