RPC: Remove cs_main lock from blockToJSON, blockHeaderToJSON and TxToJSON #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202201_blockToJSON
branch
2 times, most recently
from
60ab6f1 to
ac391cd
Compare
Fuzzbawls
reviewed
Feb 1, 2022
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
a few minor static analysis nits, otherwise functional ACK
random-zebra
force-pushed
the
202201_blockToJSON
branch
from
ac391cd to
5e0d308
Compare
Author
|
Removed |
Fuzzbawls
approved these changes
Feb 3, 2022
furszy
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2728.
This pull makes blockToJSON, blockheaderToJSON, and TxToJSON free of cs_main locks by passing the chainTip and using
GetAncestorto check if a block is part of the active chain (as per bitcoin#12151).