Skip to content

[trivial] Fixing several QT related circular dependencies #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
random-zebra merged 1 commit into from
Jan 29, 2022
Merged

[trivial] Fixing several QT related circular dependencies #2727

random-zebra merged 1 commit into from
Jan 29, 2022

Conversation

@furszy
Copy link

@furszy furszy commented Jan 19, 2022

List:

  • "qt/pivx/addresseswidget -> qt/pivx/pivxgui -> qt/pivx/addresseswidget"
  • "qt/pivx/navmenuwidget -> qt/pivx/pivxgui -> qt/pivx/navmenuwidget"
  • "qt/askpassphrasedialog -> qt/pivx/pivxgui -> qt/pivx/topbar -> qt/askpassphrasedialog"
  • "qt/pivx/coldstakingwidget -> qt/pivx/tooltipmenu -> qt/pivx/pivxgui -> qt/pivx/coldstakingwidget"
  • "qt/pivx/masternodeswidget -> qt/pivx/tooltipmenu -> qt/pivx/pivxgui -> qt/pivx/masternodeswidget"
  • "qt/pivx/pivxgui -> qt/pivx/send -> qt/pivx/tooltipmenu -> qt/pivx/pivxgui"
  • "chainparamsbase -> util/system -> logging -> chainparamsbase"

@furszy furszy self-assigned this Jan 19, 2022
@furszy furszy added the Cleanup label Jan 19, 2022
@furszy furszy added this to the 6.0.0 milestone Jan 19, 2022
random-zebra
random-zebra previously approved these changes Jan 20, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 71015dedb749d3ceb95b800b103810f76ca31076

@furszy furszy force-pushed the 2022_fix_circ_dependencies branch from 71015de to 8c788b9 Compare January 25, 2022 13:39
@furszy
Copy link
Author

furszy commented Jan 25, 2022

rebased due conflicts.

random-zebra
random-zebra approved these changes Jan 25, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 8c788b9

Fuzzbawls
Fuzzbawls approved these changes Jan 29, 2022
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8c788b9

@random-zebra random-zebra merged commit 4875988 into PIVX-Project:master Jan 29, 2022
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

Cleanup

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra