Finish moving tier two initialization code from init.cpp to tiertwo/init.cpp and add disabledkg init flag #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2022_decouple_tiertwo_init
branch
from
1f6aadd to
7be3367
Compare
1) Walk-through the DMN list only once instead of one-time per wallet. 2) Remove wallet dependency on evo/deterministicmns.h.
…al transactions' output lock in wallet to the tiertwo/init.cpp file.
furszy
force-pushed
the
2022_decouple_tiertwo_init
branch
from
7be3367 to
cc0fdeb
Compare
Author
|
Rebased on master, ready to go. Forgot to mention on the PR description that this is removing another circular dependency: |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Code ACK cc0fdeb60055f04687391950eb0882a5b6219563
Updating p2p_quorum_connect.py test with it And move -pushversion to GetTierTwoHelpString as well.
furszy
force-pushed
the
2022_decouple_tiertwo_init
branch
from
cc0fdeb to
c445333
Compare
Author
|
updated per feedback. |
Fuzzbawls
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #2684, built on top of #2647. Starting in 296e6fa0.
Focused on the following points:
GetTierTwoHelpString(), the tier two objects initializers and the Masternodes collateral output locking process to the tiertwo/init files.evo/deterministicmns.h.-disabledkginit argument so thep2p_quorum_connect.pyfunctional test does not get affected by the automatic DKG sessions processes (coming in Long Living Masternode Quorums - Part 3, DKG #2722). The same flag will be used in other future tests that perform manual operations as well.