[GUI] Decouple legacy MNs code from the GUI elements #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
furszy
changed the title
Author
|
Ended up moving the collateral min conf value to |
random-zebra
previously approved these changes
Jan 18, 2022
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
ACK e364c34456959cc861bfec1ceda1d653af8019da. Just few nits
furszy
force-pushed
the
2022_GUI_encapsulate_legacy_mn
branch
from
e364c34 to
c42547e
Compare
Author
|
updated per feedback, nits tackled |
random-zebra
previously approved these changes
Jan 18, 2022
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
force-push utACK c42547e7992778a2f304257c359528db08431422
Fuzzbawls
previously approved these changes
Jan 29, 2022
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK c42547e7992778a2f304257c359528db08431422
…N inside MNModel.
This field is used for both types, legacy and deterministic.
furszy
force-pushed
the
2022_GUI_encapsulate_legacy_mn
branch
from
c42547e to
42b6a73
Compare
Author
|
rebased, conflicts solved. |
furszy
force-pushed
the
2022_GUI_encapsulate_legacy_mn
branch
from
42b6a73 to
18e270d
Compare
Fuzzbawls
approved these changes
Jan 31, 2022
furszy
added a commit
that referenced
this pull request
Feb 8, 2022
…fix and more circ dependencies fixes 4e14d21 bug: remove 'evodb' dir during -resync (furszy) 7408131 init: move 'pEvoNotificationInterface' initialization, reset and register to tiertwo/init.cpp (furszy) 922fa05 wallet: merge GetMasternodeVinAndKeys and GetVinAndKeysFromOutput functions. (furszy) 083fcad Move masternodeconfig initialization to tiertwo/init (furszy) Pull request description: Built on top of #2721, decoupled from the DMN GUI branch. Focused on the following points: * Unify `masternodeconfig` duplicated initialization inside `tiertwo/init.cpp`. Same for the `pEvoNotificationInterface` class. * Simplify and unify `CWallet::GetMasternodeVinAndKeys` and `CWallet::GetVinAndKeysFromOutput` functions. * Bug fix: remove 'evodb' dir during `-resync`. * Fix the following circular dependencies: --> "masternode -> wallet/wallet -> masternode" --> "chain -> legacy/stakemodifier -> stakeinput -> wallet/wallet -> evo/deterministicmns -> chain" Next PR will be exclusively focused on the new tier two module. ACKs for top commit: random-zebra: force-push utACK 4e14d21 Tree-SHA512: 1c74975acb926f2410f651fc95c5dc437aa1b272ad4e0b27c50087d96908d183d85dd5b9c11528482d25d3062a1efc80bdf0567098724157912bb2a68566a5cc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encapsulating the legacy Masternodes code that is spread over the GUI widgets inside the MN module.
Plus, as is a value shared between legacy and deterministic Masternodes, moved the collateral min conf field to
chainparams. Which allowed to remove the following circular dependency:"evo/deterministicmns -> masternode -> wallet/wallet -> evo/deterministicmns"Part of the building blocks for adding visual support for the new deterministic Masternodes features.