[GUI] Don't error on zero amount for new cold staking address #2716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The amount/value field is optional for cold staking address generation.
furszy
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new payment requests via the UI, it doesn't make sense to have an empty/zero value for the amount being requested, but when creating a new cold staking address it is up to the sender how much they want to delegate, so the value at address creation time is completely optional.
This fixes the hard requirement of setting a non-zero value for cold staking address creation, and will no longer throw an error when the amount value is omitted (as the GUI indicates it is optional, which should be the intended behavior).
Also fixes a variable shadowing issue.