[Refactor] Add LookupBlockIndex #2715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
Adapted from btc@92fabcd443322dcfdf2b3477515fae79e8647d86
furszy
force-pushed
the
2021_avoid_lookups
branch
from
9c36e20 to
58779a0
Compare
Author
|
nits tackled, moved |
furszy
force-pushed
the
2021_avoid_lookups
branch
from
3f08f6d to
dc930d4
Compare
Fuzzbawls
approved these changes
Jan 19, 2022
furszy
added a commit
that referenced
this pull request
Jan 23, 2022
…ernalBlockFile 5ca8e22 QA: Fix cs_main lock in evo_deterministicmns_tests (random-zebra) 3efd1b5 Trivial: fix wrong function name in logs (random-zebra) 9b4aacf BUG: fix missing cs_main lock in AppInitMain and LoadExternalBlockFile (random-zebra) Pull request description: #2715 introduced a locking assertion in `InsertBlockIndex`, which is currently failing (with debug enabled) because `cs_main` is not held during the blockindex load in `AppInitMain` (bitcoin@c651df8). Also, `LookupBlockIndex` is being called without cs_main in `LoadExternalBlockFile` (bitcoin@f814a3e). Finally there's a couple of missing locks in rest.cpp (which can be removed later, porting bitcoin#12151). ACKs for top commit: Fuzzbawls: ACK 5ca8e22 Fuzzbawls: ACK 5ca8e22 furszy: Code ACK 5ca8e22 furszy: k, ACK 5ca8e22 and merging.. Tree-SHA512: 8775f40ffee94ca804fccffac1447bc258d6f810c601c2a8a27f3d5314c526881460a0fece903317fb9073f2d08961c3c16e9fb2a74c285db4d4b6e6028c0981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptation of 92fabcd for our sources.