[Refactor] differentiate bad-qc-quorum-hash: not-found/not-active-chain #2713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Jan 7, 2022
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jan 29, 2022
…ertain depth. ee68ff1 tiertwo validation: reject qfc older than a, network specific, depth limit. (furszy) Pull request description: Built on top of PIVX-Project#2713. Added a depth limit for the acceptance of LLMQ final commitments to prevent spam attacks like the relay of old valid qfc through the inv system. ACKs for top commit: random-zebra: utACK ee68ff1 Fuzzbawls: utACK ee68ff1 Tree-SHA512: 46b2a82f41efe72dc30b41398ca973254be2502e4d0262224d599a25db6db1042e806e79dd5412d8ba85f342a2b0c45ab120ee8b498daf7a5cd8a870c087c6f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #2699 , split
bad-qc-quorum-hashreject reason in two different cases for "hash not found" and "hash not in active chain" and add unit test coverage.