[Refactor] Deduplicate final commitment validity checks #2699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rebase needed. |
random-zebra
force-pushed
the
202112_refactor-qfc-verify
branch
from
970a18e to
2dcbe32
Compare
Author
|
Rebased |
furszy
previously approved these changes
Jan 5, 2022
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
ACK 2dcbe325011ab443d48b7d74a343b1684bf4e0fb
Would be good to add a 7c) test case for a qfc with a quorum hash from a fork (here or in a follow up work).
random-zebra
force-pushed
the
202112_refactor-qfc-verify
branch
from
2dcbe32 to
aa03eac
Compare
random-zebra
force-pushed
the
202112_refactor-qfc-verify
branch
from
aa03eac to
9e35c74
Compare
furszy
approved these changes
Jan 6, 2022
Fuzzbawls
approved these changes
Jan 7, 2022
furszy
added a commit
that referenced
this pull request
Jan 13, 2022
…ot-active-chain 2365261 Refactor: differentiate bad-qc-quorum-hash: not-found/not-active-chain (random-zebra) Pull request description: As discussed in #2699 , split `bad-qc-quorum-hash` reject reason in two different cases for "hash not found" and "hash not in active chain" and add unit test coverage. ACKs for top commit: furszy: good 👍, ACK 2365261 Tree-SHA512: 7fd56a6f6ec448f2326b4a059b8b4adb2d33e7ab1dbe90791e70ad3a67fee87ddb61dac0dfb08c068d702dc927ca4b63b2c4da4691e4ef16ab6c27333764f993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And remove circular dependency
evo/deterministicmns<->llmq/quorums_utils.