Skip to content

[TierTwo] Introduce network requests manager #2686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
furszy merged 3 commits into from
Feb 15, 2022
Merged

[TierTwo] Introduce network requests manager #2686

furszy merged 3 commits into from
Feb 15, 2022

Conversation

@furszy
Copy link

@furszy furszy commented Dec 14, 2021 •
edited
Loading

Built on top of #2684

An object in charge of cache and store tier two network requests information, preventing possible bans for asking the same data too often.

@furszy furszy self-assigned this Dec 14, 2021
@furszy furszy added this to the 6.0.0 milestone Dec 14, 2021
@furszy furszy added the Network label Dec 14, 2021
@furszy furszy changed the title [TierTwo] Introduce network requests manager [WIP][TierTwo] Introduce network requests manager Dec 14, 2021
@furszy furszy force-pushed the 2021_net_requests_manager branch 2 times, most recently from ddfc90a to 592bf23 Compare January 10, 2022 12:54
@furszy furszy force-pushed the 2021_net_requests_manager branch 4 times, most recently from e4f8b14 to 2d04d7b Compare February 6, 2022 14:12
@furszy furszy changed the title [WIP][TierTwo] Introduce network requests manager [TierTwo] Introduce network requests manager Feb 6, 2022
@furszy
Copy link
Author

furszy commented Feb 6, 2022

Rebased, conflicts and compilation issue solved. Ready to go.

@furszy furszy force-pushed the 2021_net_requests_manager branch from 2d04d7b to 88017e1 Compare February 6, 2022 21:40
random-zebra
random-zebra reviewed Feb 9, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK.
Aside a couple of nits, it seems that the netfulfilled manager is not persisted to disk. We should probably add

CFlatDB<CNetFulfilledRequestManager>("netrequests.dat", "magicNetRequestsCache").Dump(g_netfulfilledman);

to DumpTierTwo().

@furszy
Copy link
Author

furszy commented Feb 9, 2022

good catch, adding the dump.

@furszy furszy force-pushed the 2021_net_requests_manager branch from 88017e1 to 4b91b0c Compare February 9, 2022 13:35
@furszy
Copy link
Author

furszy commented Feb 9, 2022

Updated per feedback.

random-zebra
random-zebra reviewed Feb 10, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the suggested change the argument pathDB of LoadTierTwo can be removed.

@furszy furszy force-pushed the 2021_net_requests_manager branch from 4b91b0c to be1c0fc Compare February 10, 2022 12:35
@furszy
Copy link
Author

furszy commented Feb 10, 2022

great zebra 👍 , suggestions applied.

random-zebra
random-zebra approved these changes Feb 11, 2022
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be1c0fc

Fuzzbawls
Fuzzbawls approved these changes Feb 15, 2022
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK be1c0fc

@furszy furszy merged commit 204770a into PIVX-Project:master Feb 15, 2022
@Fuzzbawls Fuzzbawls modified the milestones: 6.0.0, 5.5.0 Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

Network

Projects

None yet

Milestone

5.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra