[Refactoring] Break deterministic mns circular dependencies #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
reviewed
Nov 28, 2021
furszy
previously approved these changes
Nov 28, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Code review ACK f7c2663.
extra nit: would rename the specialtx.h/cpp files to validation_specialtx.h/cpp.
random-zebra
force-pushed
the
202111_dmns-circ-dep
branch
from
f7c2663 to
cbc874e
Compare
Author
|
Rebased, file renamed, and dropped unused header imports. |
random-zebra
force-pushed
the
202111_dmns-circ-dep
branch
from
cbc874e to
0a67b8f
Compare
Author
|
Rebased, fixing conflict in the circular dependency list. |
furszy
previously approved these changes
Nov 29, 2021
In order to validate the masternode collateral utxo. Instead encapsulate GetUTXOCoin in CCoinsViewCache, and provide a pointer/reference to the view from the validation code to CheckSpecialTx/ProcessSpecialTxsInBlock. Remove unneeded GetUXOHeight.
thus breaking the circular dependency deterministicmns <-> specialtx
thus making providertx responsible only of the definition of the payload primitives (therefore not depending on deterministicmns). this breaks several circular dependencies.
which eliminates 5 circular dependencies
random-zebra
force-pushed
the
202111_dmns-circ-dep
branch
from
0a67b8f to
037abb5
Compare
furszy
approved these changes
Dec 1, 2021
Fuzzbawls
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes several circular dependencies related to deterministic masternodes code.
The chain of dependencies now is:
validation->specialtx(containing the specialtx validation/processing code) ->deterministicmns(containing the dmn manager)Functions defined in
specialtxnow take a view of the coins cache as parameter, thus no longer depend onvalidationand only requirecoins.Both
specialtxanddeterministicmnsdepend onprovidertx, which now is responsible only for the definition of each payload class and does not depend on any of the previous modules.Also, add more unit tests for invalid collateral in ProReg txes.