[GUI][BugFix] Schedule proposal broadcast only if the block has not passed yet #2626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…start has not passed yet
Fuzzbawls
approved these changes
Nov 6, 2021
furszy
added a commit
that referenced
this pull request
Nov 6, 2021
…e app window width isn't big enough 4de2338 GUI: correct proposal large title for being cut if the app window is too small. (furszy) Pull request description: Found it while was testing #2626, a small bug that occurs when the app window width isn't big enough to automatically expand the three column grid proposal cards. So the last letter of proposals with large names are being cut. For example, look at the proposal in the middle: Before the fix: <img width="1034" alt="Screen Shot 2021-11-04 at 6 44 15 PM" src="https://user-images.githubusercontent.com/5377650/140424886-366c12bc-4ce3-43c4-bcd6-89d35ec0f634.png"> After the fix: <img width="944" alt="Screen Shot 2021-11-04 at 6 40 09 PM" src="https://user-images.githubusercontent.com/5377650/140424926-3e7965ae-1db6-4c3e-9f5c-d2adb3098b4b.png"> ACKs for top commit: random-zebra: ACK 4de2338 Fuzzbawls: ACK 4de2338 Tree-SHA512: 077bd8ea8658decfa9209933ee190605597bd1397aaa66573c7745a3b38ceb3a83c360be693c8d0c3960133d78ce5f5de47d2a57858ef654bde0001b333ea73e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small follow-up to #2406, solving zebra's comment: #2406 (comment).
Fixing the not schedule of waiting proposals for broadcast at startup. Which caused that if the wallet was restarted in the middle of the broadcast process, the waiting proposals will not enter in the broadcast queue.