[wallet] Fix "null" backup file name. #2625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
changed the title
furszy
changed the title
furszy
force-pushed
the
2021_wallet_fix_automatic_backup
branch
from
ffe28f1 to
e861034
Compare
New created wallets have no name set by default, thus the `GetUniqueWalletBackupName` function returns "null", and the automatic backup process creates a backup file with a name in the form of "null+date". Changed the label to "wallet_backup" instead of "null" if the wallet has no name.
furszy
force-pushed
the
2021_wallet_fix_automatic_backup
branch
from
e861034 to
3d97ae9
Compare
Fuzzbawls
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New created wallets have no name set by default, thus why the
GetUniqueWalletBackupNamefunction returns "null", and the automatic backup process creates backup files with a name in the form of "null+date".Changed the label to "wallet_backup" instead of "null" if the wallet has no name, plus fixed the rolling functionality that was not cleaning old files.