[GUI] Show disk space requirement per-network #2621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces per-network required disk space into the intro UI in the least intrusive way for now. Mainnet and Testnet have their own static const variables, whereas Regtest is always set to "0"
furszy
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces per-network required disk space into the intro UI in the
least intrusive way for now. Mainnet and Testnet have their own static
const variables, whereas Regtest is always set to "0"
This is intended as a temporary fix for #2618, with future intention on
moving these over to chainparams a la upstream and using a node IPC
interface layer, which we do not have yet.
Can be tested by passing
-choosedatadirwith a combination of-testnet,-regtest, or standalone, and this has zero impact on translation strings.