[Net][GUI][RPC] Add enable/disable network activity feature #2606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
added
the
Needs Release Notes
furszy
force-pushed
the
2021_net_suspend
branch
from
1b477fe to
769ec19
Compare
Author
|
rebased on master, conflicts solved. |
backports btc@7c9a98aac843c9efabd8653caebc35e968b2f335
furszy
force-pushed
the
2021_net_suspend
branch
from
769ec19 to
1f21536
Compare
Author
|
rebased, conflicts solved. |
Fuzzbawls
previously approved these changes
Dec 18, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 1f21536fd744a2153757a396ea1e14b765bfe80c
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Looking good. One minor thing: the checked state of the buttons pushNetEnable/pushNetDisable should change if the activity has been changed via RPC.
furszy
force-pushed
the
2021_net_suspend
branch
from
1f21536 to
102dcaf
Compare
Author
|
done, updated per feedback. |
Fuzzbawls
approved these changes
Dec 29, 2021
Fuzzbawls
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing the user/test to stop and restart the network activity.
Pretty useful for some manual isolation test cases.
When the network activity is disabled the client will close all connections, stop accepting inbound connections, and stop opening new outbound connections, until the network activity is reenabled.
Quick demo video:
network_activity.mp4
TODO:
Add release-notes for the new RPC command and the GUI control.