Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Oct 5, 2021

Chains diagram:

A -- B -- C -- D -- E -- F -- G -- H
           \
             -- D1 -- E1 -- F1
           \
             -- D2 -- E2 -- F2
           \
             -- D3 -- E3 -- F3 -- G3 -- H3 
           \
             -- D4 -- E4 -- F4

Coverage added on this work:

  1. coins created in D1 and spent in E1. --> expected result: pass.
  2. coins created in E, being spent in D4 --> expected result: reject.
  3. coins created and spent in E2, being double spent in F2. --> expected result: reject.
  4. coins created in D and spent in E3. --> expected result: reject.
  5. coins create in D, spent in F and then double spent in F3. --> expected result: reject.
  6. coins created in G and G3, being spent in H and H3 --> expected result: pass.

@furszy furszy self-assigned this Oct 5, 2021
@furszy furszy added this to the 5.4.0 milestone Oct 5, 2021
@furszy furszy changed the title [Test] Secondary chains acceptance test coverage [WIP][Test] Secondary chains acceptance test coverage Oct 6, 2021
@furszy furszy force-pushed the 2021_test_acceptBlock branch from ae0c89a to a2eeb95 Compare October 6, 2021 17:59
@furszy furszy changed the title [WIP][Test] Secondary chains acceptance test coverage [Test] Secondary chains acceptance test coverage Oct 6, 2021
@furszy furszy added the Tests label Oct 6, 2021
@furszy furszy force-pushed the 2021_test_acceptBlock branch from a2eeb95 to b61cf58 Compare October 11, 2021 20:58
random-zebra
random-zebra previously approved these changes Oct 21, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few nits. Otherwise ACK b61cf5856135d0508e82c0021d7e595094585b05

… loop.

So the stakeable utxo loop can be stopped or not by external conditions and used in tests to create different chain branches.
… spent in E3 and (2) coins create in D, spent in F and then double spent in F3
Reorg test and case for coinstake on different chains
@furszy
Copy link
Author

furszy commented Oct 21, 2021

good, nits tackled.

random-zebra
random-zebra previously approved these changes Oct 21, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 81c3e12458424debb3c3c87c8f915dbc32836aea

Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-utACK 8c7dd6c

@furszy furszy merged commit 9c47a10 into PIVX-Project:master Nov 9, 2021
@furszy furszy deleted the 2021_test_acceptBlock branch November 29, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants