Skip to content

[GUI] Include MN Rewards in the dashboard chart #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fuzzbawls merged 2 commits into from
Nov 23, 2021
Merged

[GUI] Include MN Rewards in the dashboard chart #2577

Fuzzbawls merged 2 commits into from
Nov 23, 2021

Conversation

@furszy
Copy link

@furszy furszy commented Sep 30, 2021 •
edited
Loading

Revival of #1362 with further cleanup.

As we don't have zPIV anymore, this PR removes it from the dashboard chart and include the Masternodes rewards instead.

@furszy furszy self-assigned this Sep 30, 2021
@furszy furszy changed the title [WIP][GUI] Include MN Rewards in the dashboard chart [GUI] Include MN Rewards in the dashboard chart Sep 30, 2021
@furszy furszy added this to the 5.4.0 milestone Oct 1, 2021
@furszy furszy added the GUI label Oct 1, 2021
@furszy furszy requested a review from ambassador000 October 3, 2021 15:12
@furszy furszy mentioned this pull request Oct 3, 2021
Closed
@Fuzzbawls
Copy link
Collaborator

Fuzzbawls commented Oct 4, 2021

So far this is looking good.

From a visual/presentation perspective, I would maybe change some verbiage though. "PIV" as a column label, for example, is ambiguous, as both staking and MN rewards are both paid out in "PIV".

Given the string changes to the chart description, I think that it may be better to have the column key labels read as "Staking" and "Masternode" respectively, instead of "PIV" and "MN Rewards" especially since "rewards" is implied for both.

@furszy furszy force-pushed the 2021_GUI_MN_rewards_chart branch from d1d9f73 to e97e482 Compare November 21, 2021 14:26
@furszy
Copy link
Author

furszy commented Nov 21, 2021

sure agree, updated per feedback 👍 . (plus rebased on master).

@furszy furszy force-pushed the 2021_GUI_MN_rewards_chart branch from e97e482 to 43af279 Compare November 21, 2021 14:37
random-zebra
random-zebra previously approved these changes Nov 22, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TransactionFilterProxy::addrPrefix is unused now and can be removed.
Other than this, tested ACK 43af2794dd0b24c1fd07321aad55280ff0bb92b2

@furszy furszy force-pushed the 2021_GUI_MN_rewards_chart branch from 43af279 to efc2198 Compare November 22, 2021 12:50
@furszy
Copy link
Author

furszy commented Nov 22, 2021

good, removed the unused member. Squashed in 222a511

random-zebra
random-zebra approved these changes Nov 22, 2021
View reviewed changes
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK efc2198

Fuzzbawls
Fuzzbawls approved these changes Nov 23, 2021
View reviewed changes
Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK efc2198

@Fuzzbawls Fuzzbawls merged commit a6d11e1 into PIVX-Project:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fuzzbawls Fuzzbawls Fuzzbawls approved these changes

@ambassador000 ambassador000 Awaiting requested review from ambassador000

+1 more reviewer

@random-zebra random-zebra random-zebra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@furszy furszy

Labels

GUI

Projects

None yet

Milestone

5.4.0

Development

Successfully merging this pull request may close these issues.

3 participants

@furszy @Fuzzbawls @random-zebra