[BUG][GUI] Refine bytes/fee/"after fee" calculation in coin-control #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
approved these changes
Oct 11, 2021
furszy
added a commit
that referenced
this pull request
Oct 16, 2021
ac81ee6 GUI: bugfix, set locked label invisible for shield notes. (furszy) 6cdb6df sendmany: fix not set min depth for legacy transactions. (furszy) 74c4b9d [BUG][GUI] Refine bytes/fee/"after fee" calculation in coin-control (random-zebra) a5d236a GUI: dashboard chart, fix last day of the month not being shown. (furszy) Pull request description: List of PRs to backport to the v5.3 branch for a small and concrete bugs fixing release v5.3.2.1 (zero risk release). * #2568 * #2578 * #2592 * #2593 ACKs for top commit: random-zebra: utACK ac81ee6 Fuzzbawls: ACK ac81ee6 Tree-SHA512: 81a69e3e7ee342c4194cd34b9d230e6c2cfe5a77d3b58631aeb69406caf4e14a82f521b9df9f9953fcad6d93044e76740523b3e8eaa7d4ec6bf3079b6b2b6c95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #2156
This bug is caused by the fact that a transparent input is usally 148 bytes (149 for p2cs spends), but can also be 149 sometimes (150 for p2cs spends), depending on the script length.
When a user copies "After fee" in coin-control, and sends it to a single recipient, this extra fee is typically (with few coins selected) offset by the lack of change output. But, when many inputs are selected in coin control, this becomes relevant.
Also:
CTXIN_SPEND_DUST_SIZEandCTXOUT_REGULAR_SIZEinsapling_operation.h