[BUG][TierTwo] MNB process refactor #2567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_mnb_process_refactoring
branch
2 times, most recently
from
105b1d6 to
126314d
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Good find for the un-checked return value of Add(). 👍
But I think it would be better to move the dmn-collateral-reuse test out of Add(), and place it at the beginning of ProcessMNBroadcast (where it should have been in the first place, as it is much faster than the following tests).
Author
|
Agree on the dmn-collateral reuse check movement out of |
furszy
changed the title
…ast:CheckInputsAndAdd' function.
The location where this function should have been placed in the first place..
if the mnb received is from an active DMN, it needs to not be relayed to the network as it's an invalid mnb that no node will accept.
furszy
force-pushed
the
2021_mnb_process_refactoring
branch
from
126314d to
cb6740a
Compare
Author
|
rebased on master so it gets the latest tier two bugs fixes. |
random-zebra
reviewed
Oct 8, 2021
…ckInputs. Accessing to the utxo in the coins cache view only once, when the collateral availability is checked.
furszy
force-pushed
the
2021_mnb_process_refactoring
branch
from
cb6740a to
4a67ede
Compare
Author
|
feedback tackled. |
Fuzzbawls
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have refactored the mnb validation process, placing the code where it should had been in the first place (masternode manager and not be an internal masternode function that is called from and internally calls to the manager..).
Doing it found a bug over the MN-DMN compatibility code:
if the mnb received is from an active DMN, it needs to not be relayed to the network as it's an invalid mnb that no node will accept. Active DMNs have prevalence over regular MNs.
And improved an un-performant, on disk, tx look up to check the mnb pubkey association with the collateral key. Use the coins cache instead.