[Refactor] Remove code duplication in sign/verify message rpc/gui #2556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just use CMessageSigner
random-zebra
force-pushed
the
202109_refactor-signmessage-rpc-gui
branch
from
8745e50 to
7d5a01d
Compare
Author
|
Rebased on master. |
furszy
approved these changes
Sep 23, 2021
Fuzzbawls
approved these changes
Sep 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple refactoring commit to remove some code duplication. No functional changes.
note:
currently this PR includes
for easier rebase later: as here we replace the
util/validation.hheader include (introduced in #2548) withmessagesigner.h, wherestrMessageMagicwas accessed directly.