[Wallet] Sapling, restructure increment witnesses workflow #2539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work aims to improve the structure and performance of the wallet's Sapling increment witnesses flow.
The process is essentially walking through the entire wallet's txs map a minimum of 2 times, if there is no shield tx in the arriving block, and adds one more for each shield tx inside the block. Which affects mainly to wallets with a large number of transactions as the wallet is locked while this operation is being executed.
So, straight to the point, the current increment witness workflow is:
And, have re-structured it into:
Finishing with only one loop over the wallet's txs map in the entire increment witnesses workflow.
PD: The benchmark that did is still a bit raw..