[Build] Add M1 mac homebrew path #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Homebrew installs on Apple M1 based systems now use /opt/homebrew as the base path.
Homebrew installs on Apple M1 based systems now use /opt/homebrew as the base path.
random-zebra
approved these changes
Sep 15, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK df45553
Don't have a M1 machine at my disposal to test this with, but the change looks good (also comparing with upstream bitcoin#21231).
Note: for the same reason we might want to backport bitcoin#22397 too.
Collaborator
Author
|
yep, that is on my list. wanted to get this done first as it allows the finding of required dependencies that otherwise cause the build to fail |
furszy
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Homebrew installs on Apple M1 based systems now use
/opt/homebrewas the base path. This adds such path to the search paths for both autotools and cmake. PIVX-Project/bls-signatures#9 will also be needed in a future PR to compliment this.