[Tests] Require exact match in assert_raises_init_error #2489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202107_qaRegexInitError
branch
from
0fdfef8 to
e6119ed
Compare
Author
|
Backported bitcoin#12853 too, and added a scripted commit to update the comments still mentioning |
furszy
previously approved these changes
Jul 27, 2021
random-zebra
force-pushed
the
202107_qaRegexInitError
branch
from
e6119ed to
bbabef1
Compare
Author
|
Rebased on master, to include |
furszy
previously approved these changes
Jul 30, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
re-utACK bbabef1dc290fc1943f87817f562ebfa121938d8
Fuzzbawls
reviewed
Jul 31, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
minor typo in assert_start_raises_init_error(), otherwise ACK
This allows the tests to pass on different platforms
-BEGIN VERIFY SCRIPT- sed -i 's/bitcoind/pivxd/' test/functional/*.py test/functional/*/*.py -END VERIFY SCRIPT-
random-zebra
force-pushed
the
202107_qaRegexInitError
branch
from
bbabef1 to
84768b5
Compare
Fuzzbawls
approved these changes
Aug 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports
This completes the todo left for