[BUG][GUI] Fix broken tutorial screen #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `-wallet` arguments can now represent paths to existing directories or symlinks (by default it is empty, representing the path relative to the datadir, i.e. the datadir itself). It does not include the *filename* (unless explicitely specified in `-wallet`) anymore. Therefore the tutorial screen is never created (even on fresh installs). Also, we are using `GetArg`, which returns the last argument from command line (or first argument in conf file), and not checking all the files with `GetArgs`.
random-zebra
added
GUI
Bug
Wallet
Startup
furszy
approved these changes
Jul 23, 2021
Fuzzbawls
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI tutorial screen (where the user selects the language and gets the first few "beginner tips") is supposed to be fired when the wallet.dat file is not found, before creating it for the first time.
In case of multiple wallets (using the
walletoption in the config file, or as startup flag), the tutorial screen should not be fired if at least one wallet.dat already exists.The check to decide whether or not to prompt the tutorial screen was broken in #2423.
The
-walletarguments can now represent paths to existing directories or symlinks (by default it is empty, representing the path relative to the datadir, i.e. the datadir itself).It does not include the filename anymore (unless explicitly provided to
-wallet).Therefore the tutorial screen is never created on the first launch, as it should.
Also, we are using
GetArg, which returns the last argument from command line (or first argument in conf file), and not checking all the files withGetArgs.