[Refactor] Make HexStr take a span #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_make_HexStr_take_span
branch
from
485ab84 to
ff44897
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Looking good. Few unneeded conversions to vector for c-arrays.
Author
|
updated per feedback. |
furszy
force-pushed
the
2021_make_HexStr_take_span
branch
from
ff44897 to
2770504
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Not compiling due to a typo. Also needs rebase.
furszy
force-pushed
the
2021_make_HexStr_take_span
branch
from
2770504 to
92aa2e6
Compare
Problem: - Nothing uses the `fspaces` argument to `HexStr()` besides unit tests. This argument results in extra complexity and a small performance decrease within the function for branch evaluation. Solution: - Remove unused `fspaces` option.
furszy
force-pushed
the
2021_make_HexStr_take_span
branch
from
92aa2e6 to
d4408cd
Compare
Author
|
updated per feedback + rebased. |
Fuzzbawls
approved these changes
Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2470. Only the last two commits are from this work.
Make
HexStrtake a span of bytes, instead of an awkward pair of templated iterators. Simplifying most of the uses.Adaptation of bitcoin#19660 and bitcoin#15573.