[Backport] git-subtree-check.sh updated to latest upstream #2473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_update_subtree_check
branch
2 times, most recently
from
2406eff to
5025ba5
Compare
Author
|
rebased due conflicts with a recent merged PR. |
random-zebra
previously approved these changes
Jul 19, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 5025ba556e3c0b3ae1a139976e6a4d75e8c941d9
Fuzzbawls
previously approved these changes
Jul 21, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 5025ba556e3c0b3ae1a139976e6a4d75e8c941d9 with a note:
The location of this shell script was changed in #2452 (from contrib/devtools to test/lint). when that PR was merged it prompted this to be rebased. a previous comment here was to PIVXify the help text, which included referencing the (correct-at-the-time) script's location in the tree as contrib/devtools.
Post #2452 merge and after rebase, the help text should be referencing test/lint. Other than that, GTG
Author
|
yeah, will push it shortly. |
Plus use bls-repo in the help example.
furszy
force-pushed
the
2021_update_subtree_check
branch
from
5025ba5 to
855aa70
Compare
Author
|
Updated, can get merged right away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled latest
git-subtree-check.shchanges from upstream. So it's easier to verify the new subtree that is being included in #2419.