[Build] fix GA boost test random seed number overflow #2471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The random seed value is interpreted as an unsigned int inside boost test and github's run_id value is overflowing the type range.
furszy
force-pushed
the
2021_fix_GA_boost_test
branch
from
e5c4f47 to
c3d0d65
Compare
Fuzzbawls
approved these changes
Jul 6, 2021
Collaborator
Fuzzbawls
left a comment
Fuzzbawls
left a comment
There was a problem hiding this comment.
ACK 5e6200b57a06e1ed2f0d0c522da5333cfb5c2786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The random seed value, used in boost for shuffling the unit tests order, is interpreted as an unsigned int inside the boost test framework and the current value is overflowing the type range, thus why GA is failing in every PR and commit.
Solution: use the framework functionality to select a random seed based on the current time (can check it inside boost documentation link).