[WIP][bugFix] Wrong use of ASSERT_WITH_MSG in validation_block_tests and missing validation state set.
#2463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons why we are having GA failures in
validation_block_tests:ASSERT_WITH_MSGis defined asASSERT_WITH_MSG(validCondition, errorCauseStr)and notASSERT_WITH_MSG(invalidCondition, errorCauseStr).CheckBlockis receiving blocks out of order and failing without setting the proper validation state.Future: Move tip contextual checks in
CheckBlockto Accept/ConnectBlock.