1. nStatus of CBlockIndex  is consistent with the definition of
Enum(BlockStatus)

2. The BlockHeader is consistent with the type of variable defined in
CBlockHeader

Plus a use of std::copy() instead of manual copying.

>>> adaptation of bitcoin/bitcoin@58d91af

>>> adapts bitcoin/bitcoin@d223bc9

* pcoinscatcher (CCoinsViewErrorCatcher)
* pcoinsdbview (CCoinsViewDB)
* pcoinsTip (CCoinsViewCache)
* pblocktree (CBlockTreeDB)
* Remove variables shadowing pcoinsdbview

--- PIVX:
use unique_ptr also for
* zerocoinDB
* pSporkDB

>>> backports bitcoin/bitcoin@3e09b39
             +bitcoin@a357293

std::unordered_map::erase( const_iterator pos ) returns an iterator to the element following the removed one. Use that to optimize (probably minor-performance-wise, and definitely code-structure-wise) the implementation of CCoinsViewCache::BatchWrite().

(remove "enum hack")

Move to AppInitServers. This doesn't have any effects on bitcoin
behavior. It was just strange to have this unrelated code in the middle
or parameter interaction.

Before this commit:

  for (std::map<T1, T2>::iterator x = y.begin(); x != y.end(); ++x) {
  }

After this commit:

  for (auto& x : y) {
  }

Make the non-const overload of CBlockIndex::GetAncestor() reuse the
const overload implementation instead of the other way around. This way,
the constness of the const overload implementation is guaranteed. The
other way around, it was possible to implement the non-const overload in
a way which mutates the object, and since that implementation would be
called even for const objects (due to the reuse), we would get undefined
behavior.

…+/- 1 byte for HMAC-SHA256 and 128 bytes +/- 1 byte for HMAC-SHA512

>>> adapts bitcoin/bitcoin@a720b92

Remove includes in .cpp files for things the corresponding .h file
already included

char, etc.).

std::string::find has a character based overload as can be seen here
(4th oveload): http://www.cplusplus.com/reference/string/string/find/

Use that instead of constantly allocating temporary strings.