[Refactor] Create generic CallResult and connect it to getNewAddress* functions. #2453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_generalize_operation_result
branch
2 times, most recently
from
43506de to
38f95cb
Compare
furszy
force-pushed
the
2021_generalize_operation_result
branch
from
38f95cb to
9f24a69
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Nice. Code review ACK, with some ideas/questions.
furszy
force-pushed
the
2021_generalize_operation_result
branch
2 times, most recently
from
54d513a to
4f31b65
Compare
…::getNewAddress` and `CWallet::getNewStakingAddress` methods.
…l::getNewAddress` and `WalletModel::getNewStakingAddress` methods.
…lResult<Destination> abstraction. No more ref args. Plus moved Destination functions implementation to cpp file.
furszy
force-pushed
the
2021_generalize_operation_result
branch
from
4f31b65 to
c4fb14d
Compare
Fuzzbawls
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a generic
CallResultclass, inheriting fromOperationResult, to be used instead ofPairResult. Improving and cleaning several flows, removing the ugly ref inputs used to return the functions result object and the error string.Changes scoped to the
CWallet::getNewAddress,CWallet::getNewStakingAddress,WalletModel::getNewAddressandWalletModel::getNewStakingAddressfunctions only.Future: can be used in several other places to cleanup long function signatures with ref args used to return the result object and the error string with a boolean flag.