[Test] Extended test coverage for chain reorg during superblock and payments order. #2438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_test_budget_reorg_and_payment_order
branch
from
e754977 to
96a4fad
Compare
furszy
force-pushed
the
2021_test_budget_reorg_and_payment_order
branch
4 times, most recently
from
d88a596 to
9711d99
Compare
furszy
requested review from
Fuzzbawls and
random-zebra
and removed request for
Fuzzbawls
… amount of votes only.
furszy
force-pushed
the
2021_test_budget_reorg_and_payment_order
branch
from
9711d99 to
0961e50
Compare
random-zebra
previously approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Looks good. tiertwo_governance_invalid_budget.py could use some more cleanup (removing the unused node minerB, leftover from tiertwo_reorg_mempool.py):
Index: test/functional/tiertwo_governance_invalid_budget.py
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/test/functional/tiertwo_governance_invalid_budget.py b/test/functional/tiertwo_governance_invalid_budget.py
--- a/test/functional/tiertwo_governance_invalid_budget.py (revision 0961e50fd575ec00950e2925d4be77a6c144e0bb)
+++ b/test/functional/tiertwo_governance_invalid_budget.py (date 1626277927433)
@@ -16,19 +16,17 @@
def set_test_params(self):
self.setup_clean_chain = True
- # 4 nodes:
+ # 3 nodes:
# - 1 miner/mncontroller
# - 2 remote mns
- # - 1 other node to stake a forked chain
- self.num_nodes = 4
+ self.num_nodes = 3
self.extra_args = [["-sporkkey=932HEevBSujW2ud7RfB1YF91AFygbBRQj3de3LyaCRqNzKKgWXi"],
[],
- ["-listen", "-externalip=127.0.0.1"],
- ["-listen", "-externalip=127.0.0.1"],
+ [],
]
self.enable_mocktime()
- self.minerAPos = 0
+ self.minerPos = 0
self.remoteOnePos = 1
self.remoteTwoPos = 2
@@ -39,27 +37,27 @@
self.mnTwoPrivkey = "92Hkebp3RHdDidGZ7ARgS4orxJAGyFUPDXNqtsYsiwho1HGVRbF"
def run_test(self):
- self.minerA = self.nodes[self.minerAPos] # also controller of mn1 and mn2
+ self.miner = self.nodes[self.minerPos] # also controller of mn1 and mn2
self.mn1 = self.nodes[self.remoteOnePos]
self.mn2 = self.nodes[self.remoteTwoPos]
self.setupContext()
[...]
furszy
force-pushed
the
2021_test_budget_reorg_and_payment_order
branch
from
0961e50 to
4ca46e4
Compare
Author
|
Done, squashed it inside the last commit. |
furszy
force-pushed
the
2021_test_budget_reorg_and_payment_order
branch
from
4ca46e4 to
6805ee8
Compare
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jul 25, 2021
broken due to merges of PIVX-Project#2438 + PIVX-Project#2464
random-zebra
added a commit
that referenced
this pull request
Jul 25, 2021
4155b48 [Tests] Fix ProcessNewBlock signature in budget_tests.cpp (random-zebra) Pull request description: broken due to merges of #2438 + #2464 Top commit has no ACKs. Tree-SHA512: 1df1a7a45be0cdaca9409f2698220dfcf025df2fe784d28bd9d7b084a73718d4fccfad5def3296992f5bb4e78c0fea5860651b28c6e61f1c121a08e4df1e1535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #2427..
Expanded unit test coverage for the blockchain reorg during superblock range (parallel work of #2436), budget proposal payments distribution in different order and the creation of an invalid budget finalization.