[QA] Add tiertwo_governance_reorg functional test #2436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fuzzbawls
approved these changes
Jun 21, 2021
random-zebra
added a commit
that referenced
this pull request
Jun 21, 2021
4368613 [BUG] Check masternode/budget payments during block connection (random-zebra) 0374dbe [QA] Add tiertwo_governance_reorg functional test (random-zebra) Pull request description: First commit backports the functional test of #2436. Second commit extracts from f6aa6ad (#2345) the fix to make it pass. ACKs for top commit: Fuzzbawls: Code ACK 4368613 Tree-SHA512: d12cbcc59719c5a5328c04c567cfa387d98ef00565e21a2bd37a3de3d85cead7120267b04b8c121d0489be6d5c7cf726337228e4123048d1f285a2c35b826651
furszy
approved these changes
Jun 21, 2021
random-zebra
added a commit
that referenced
this pull request
Jul 24, 2021
…erblock and payments order. 6805ee8 Budget finalization, compare budget payments with existent proposals. (furszy) 25edbf4 [Test] Add test coverage for invalid budget finalization. (furszy) 7c13437 Check budget payment tx validity on the finalization with the highest amount of votes only. (furszy) c0450ea Test: coverage for budget proposals payment in different order (furszy) bf820f6 Test: Add test coverage for a block reorg during the budget proposal payment. (furszy) Pull request description: Built on top of #2427.. Expanded unit test coverage for the blockchain reorg during superblock range (parallel work of #2436), budget proposal payments distribution in different order and the creation of an invalid budget finalization. ACKs for top commit: random-zebra: utACK 6805ee8 Tree-SHA512: d70e2e24ef9aa05e0991561325674397976b49fa500c5cfcc5013f9dca65afc9223713268e6a99dadf9fec4de5e7c551ead4cc5df8c327f0a815d2dc41e21884
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional test to check chain reorganization during superblock.