[Consensus] Introduce 5.2 nuparams and use them to guard new P2CS rules #2428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
Needs Backport
furszy
previously approved these changes
Jun 18, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
utACK caad3fb57fa8d7e4b33405be21dee8fa3659932c
random-zebra
force-pushed
the
202106_nuparams-5.2
branch
from
caad3fb to
c85dc14
Compare
Author
|
Fixed couple comments |
furszy
approved these changes
Jun 18, 2021
random-zebra
removed
the
Needs Backport
Fuzzbawls
approved these changes
Jun 19, 2021
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jun 19, 2021
random-zebra
added a commit
to random-zebra/PIVX
that referenced
this pull request
Jun 19, 2021
>>> Backports caad3fb57fa8d7e4b33405be21dee8fa3659932c (PIVX-Project#2428)
furszy
added a commit
that referenced
this pull request
Jun 20, 2021
62bf095 [Consensus] use v5.2 params to guard new cold-staking rules (random-zebra) 5358c50 [Refactor] Move stack check inside CheckColdStake (random-zebra) 7bec531 [Consensus] Introduce V5.2 network-upgrade params (random-zebra) fecbb4a [Script] Strict test for IsPayToColdStaking (random-zebra) 84ed2d4 [Script] Strict checks for OP_CHECKCOLDSTAKEVERIFY (random-zebra) 9531fb8 [Tests] Proof of concept for P2CS vulnerability (random-zebra) Pull request description: Backports #2258 and #2428 ACKs for top commit: furszy: re code-ACK 62bf095 Fuzzbawls: utACK 62bf095 Tree-SHA512: 97e155f9fd84e8362f1a07ab1dd91216378f451dc3a0e756e543dfa31e37a8d53e3ffd90e2e8d67ee5e4d3a7f0fbcbd6118eaaaea7677c9682cea4c8f5e941bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title:
UPGRADE_V5_2params (withNO_ACTIVATION_HEIGHTfor now).g_IsV6Activeflag (used to guard the new P2CS rules) based on 5.2 enforcement, and renames it tog_newP2CSRules.