Skip to content

Conversation

@furszy
Copy link

@furszy furszy commented Jun 17, 2021

Adding important missing test coverage for invalid block budget payee script.

@furszy furszy self-assigned this Jun 17, 2021
@furszy furszy force-pushed the 2021_test_invalid_budget_payee branch 2 times, most recently from 1aca10e to e59f8f3 Compare June 17, 2021 02:41
@furszy furszy added the Tests label Jun 17, 2021
@furszy furszy added this to the 6.0.0 milestone Jun 17, 2021
@furszy furszy force-pushed the 2021_test_invalid_budget_payee branch from e59f8f3 to 0031bc4 Compare June 21, 2021 02:19
@random-zebra random-zebra modified the milestones: 6.0.0, 5.2.0 Jun 21, 2021
Copy link

@random-zebra random-zebra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 0031bc4

Copy link
Collaborator

@Fuzzbawls Fuzzbawls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ACK 0031bc4

@furszy furszy merged commit f1651a7 into PIVX-Project:master Jun 21, 2021
random-zebra added a commit that referenced this pull request Jul 24, 2021
…erblock and payments order.

6805ee8 Budget finalization, compare budget payments with existent proposals. (furszy)
25edbf4 [Test] Add test coverage for invalid budget finalization. (furszy)
7c13437 Check budget payment tx validity on the finalization with the highest amount of votes only. (furszy)
c0450ea Test: coverage for budget proposals payment in different order (furszy)
bf820f6 Test: Add test coverage for a block reorg during the budget proposal payment. (furszy)

Pull request description:

  Built on top of #2427..
  Expanded unit test coverage for the blockchain reorg during superblock range (parallel work of #2436), budget proposal payments distribution in different order and the creation of an invalid budget finalization.

ACKs for top commit:
  random-zebra:
    utACK 6805ee8

Tree-SHA512: d70e2e24ef9aa05e0991561325674397976b49fa500c5cfcc5013f9dca65afc9223713268e6a99dadf9fec4de5e7c551ead4cc5df8c327f0a815d2dc41e21884
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants