[Refactor] MN operator key migration to BLS #2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
random-zebra
force-pushed
the
202106_BLS_operatorkey
branch
4 times, most recently
from
b87e47f to
c22940a
Compare
random-zebra
force-pushed
the
202106_BLS_operatorkey
branch
2 times, most recently
from
72cab72 to
1451764
Compare
Author
|
Finally rebased on master. Ready to go. |
random-zebra
force-pushed
the
202106_BLS_operatorkey
branch
2 times, most recently
from
104ee73 to
d26563e
Compare
furszy
reviewed
Sep 29, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Re-reviewed till d26563ebc92d8991fcd934394a25ac399b2685cc, looking great ☕. Left few more comments
As we spoke via pm, would be better to move the last two mn payments related commits to another PR so this one is only scoped to the MN operator key migration to BLS.
Aside from that, i'm ready to ACK it :).
these will be used by mnw/fbv for deterministic masternodes, after switching the operator keys to BLS
-BEGIN VERIFY SCRIPT- sed -i 's/keyIDOperator/pubKeyOperator/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp; sed -i 's/operatorAddress/operatorPubKey/g' src/*.h src/*.cpp src/*/*.h src/*/*.cpp; -END VERIFY SCRIPT-
Also add methods to parse bls public/secret keys. These will be used by the protx_* commands after the switch of operator keys to BLS.
Only the secret key and the collateral out are needed to vote/sign
random-zebra
force-pushed
the
202106_BLS_operatorkey
branch
from
1b43f3e to
d3843cd
Compare
Author
|
Rebased on master, feedback tackled, and last 2 commits moved to #2584. |
furszy
approved these changes
Oct 4, 2021
Fuzzbawls
approved these changes
Oct 8, 2021
furszy
added a commit
that referenced
this pull request
Nov 8, 2021
e8559fc [Refactor] make AddWinningMasternode a void function (random-zebra) 5aaa02a [Test] add mnwinner case for non-existent MN. (furszy) e68773b [Refactor] Fix checks order for mnw processing (random-zebra) Pull request description: Extracted from #2421 (and based on top of it) so #2550 can be merged in between. ACKs for top commit: furszy: utACK e8559fc after rebase Tree-SHA512: 659d4ca43502f8e1e8f6ddbf7c815f6a07a69625f00c8ab71b7d8e9c97b85e90d97b18ccc988dcfd4d345d5f79932128abdaa0f0634380be7d715d3a3e45c6fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of:
As per title, introduce BLS keys/signatures for messages signed by the masternode operator (which is a requirement for DIP 6, and subsequent upgrades).
generateblskeypairreturns a new publickey/secretkey BLS keypair.CDeterministicMNState::keyIDOperatoris now aCBLSLazyPublicKey(instead of aCKeyID), and it's renamedpubKeyOperator.-mnoperatorprivatekeyflag takes a BLS secret key in hex format.CActiveMasternodeInfostores aCBLSPublicKey/CBLSSecretKey