[GUI] Fix invalid MN collateral amount and align every static 10k PIV strings. #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of the hardcoded amount.
furszy
force-pushed
the
2021_GUI_fix_regtest_mn_creation
branch
from
071939e to
780626b
Compare
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
Code ACK, minus lost html-formatting in the first screen of the mn wizard.
One minor concern I have is about the change in the FAQs.
Someone reading on a regtest wallet might think that the same applies verbatim on all networks.
But, on the other hand, someone using the regtest probably already knows what's he doing.
Author
|
Yep, i'm fine either way. |
…n collateral value.
furszy
force-pushed
the
2021_GUI_fix_regtest_mn_creation
branch
from
780626b to
3c5b5f3
Compare
Author
|
Feedback tackled, this is a bug blocking masternodes to be created in regtest. Let's merge it. |
|
merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #2296, we have a different masternode collateral output amount for regtest. As the GUI has the 10k value harcoded in some places, the masternode creation wizard got broken and there are some misaligned strings as well.
This PR fixes it and aligns every static 10k PIV string to be set dynamically consuming the chain params value.