[budget] Clean pre-v5 consensus guards for proposal start block and max payment amount #2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We cannot do this yet, or we risk forking the network, as we have still active proposals that were submitted before V5 (thus with old rules). Note that the new rules apply only if the proposal's block-start is after v5 enforcement. There are 3 of these proposals. Two of them will expire after then next cycle. But the last one still needs 4 more cycles (it has a payment count of 12, which is not even allowed by the new rules). |
Author
|
No need to merge this one now, let's leave it open until we can do it. |
furszy
force-pushed
the
2021_clean_budget_v5_rules
branch
from
9c0f399 to
3a9476c
Compare
Fuzzbawls
approved these changes
Dec 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning pre-v5 consensus guards for the proposal start block and max payment amount validation.