[Cleanup] guiutils cleanup + fix memory mismanagement #2380
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
macOS
|
Shouldn't we also hide Other than this, concept ACK. Needs rebase for conflict in the release notes file. |
Author
|
yeah, plus now that #2272 was merged, i can removed every macOS <= 10.11 check. |
furszy
force-pushed
the
2021_clean_guiutils
branch
2 times, most recently
from
1e214b0 to
20fb083
Compare
Author
|
Done, updated. Added more cleanup. Purely negative PR. |
random-zebra
previously approved these changes
May 28, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK 20fb08307fd14dbb171cd1ecfde5e30dbab89eb9
…WidgetItem from guiutil.h/cpp
-BEGIN VERIFY SCRIPT- sed -i 's/__APPLE__/MAC_OSX/g' src/compat/byteswap.h src/util/system.cpp -END VERIFY SCRIPT-
The macOS startup item code was disabled for builds targeting macOS > 10.11 in bitcoin#2272. Now that we require macOS 10.12 as a minimum, we can remove the startup item code entirely, as the API we were using was removed in macOS 10.12.
furszy
force-pushed
the
2021_clean_guiutils
branch
from
20fb083 to
2896a48
Compare
Author
|
Had to rebase it again due conflicts with the release-notes. Let's merge this one. |
Fuzzbawls
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward update for the
guiutilfiles.First commit removes unused
TableViewLastColumnResizingFixerandDHMSTableWidgetItemfromguiutil.h/cpp.Second and third commit comes from bitcoin#15208.
Fourth commit comes from bitcoin#14801.