[Test] Coverage for zc transactions rejection in mempool and blocks. #2364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furszy
force-pushed
the
2021_test_zc_rejection
branch
from
ef7f3a1 to
a6c1896
Compare
random-zebra
added a commit
that referenced
this pull request
May 5, 2021
529ff1f [Refactoring] Stop writing zerocoin mints in the DB (random-zebra) 6b51e1c [Cleanup] Remove unused ReadCoinMint/EraseCoinMint (key 'm') in zc DB (random-zebra) Pull request description: We should have never databased the "public coins" in the first place, and it's beyond useless now. With this simple removal we get a 20~25% speedup during they sync of the interested blocks [`863787` -> `1880000`], and, as bonus, we save 60MB of disk space. ACKs for top commit: Fuzzbawls: ACK 529ff1f furszy: Now that we have #2298 and #2364 test, ACK 529ff1f . Tree-SHA512: 9d053538158cd271e64ab70bc3aa913256d3a4386c02e961c2776b45b0694221d3f0919a5992c8e652271783fc2d81729df48fbbb11d0c3f1ba9704e0654c893
furszy
force-pushed
the
2021_test_zc_rejection
branch
from
a6c1896 to
981e943
Compare
random-zebra
approved these changes
May 5, 2021
Author
I know, i told you that :p. Didn't do it here because i know that you changed it inside #2360 ☕ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe-belt for the post-v5 zerocoin cleanup that is being done. Unit test ensuring that we are rejecting zc txs in the mempool and inside new blocks.