[P2P][Bug] Fix expected disconnections after not-connectable block #2361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202105_bug-connectblock_disconnectnode
branch
4 times, most recently
from
fae68b5 to
cfedd01
Compare
This bug is visible in the numerous commented "expected_disconnect" lines in feature_block.py. When the validation state is sent via the BlockChecked signal, after ConnectBlock failures in ConnectTip, the mapBlockSource is not updated yet, so there is no node to disconnect.
random-zebra
force-pushed
the
202105_bug-connectblock_disconnectnode
branch
from
cfedd01 to
2605f5b
Compare
Author
|
Rebased on master. Ready for review. |
furszy
approved these changes
May 17, 2021
Fuzzbawls
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of:
Fix a couple bugs discovered with
feature_block.Nodes not being disconnected after sending a block rejected during
ConnectBlock, as the block source is not updated yet, and nodes not being disconnected after sending a block with invalid PoW (this only affects regtest chain).