[Tests][Refactoring] Remove mocked budget manager in budget_tests #2356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Since we can directly update the sporkManager, we can check the actual function, decoupling the maps update in AddFinalizedBudget
random-zebra
force-pushed
the
202104_IsBlockValueValid-test
branch
from
1b91990 to
42be32c
Compare
Author
|
Rebased on master, ready to go. |
Fuzzbawls
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from:
and based on top of it.
Forcing the update of the spork message and finalized budget, we can test the actual
IsBlockValueValidfunction.This also refactors the spork code to update the maps in a single place, as suggested by @furszy here #2274 (comment).