[Refactoring] Completed migration of uint* classes to blob #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
force-pushed
the
202104_uint256
branch
from
2ef469a to
90059b4
Compare
furszy
reviewed
Apr 25, 2021
furszy
left a comment
furszy
left a comment
There was a problem hiding this comment.
Great work conclusion!
Code review ACK 90059b4829e530cf09eb5c74082afe3ad4260e55
Will run it some time on mainnet before giving the final approval.
random-zebra
force-pushed
the
202104_uint256
branch
from
90059b4 to
9ad9983
Compare
Author
random-zebra
force-pushed
the
202104_uint256
branch
from
9ad9983 to
7bbbae3
Compare
Author
|
Rebased again. |
random-zebra
added a commit
that referenced
this pull request
May 5, 2021
…SG usage for dynamic messages. 8ff6fa2 [test] validation_block_tests: New ASSERT_WITH_MSG to print dynamic error messages. (furszy) Pull request description: Bug discovered checking GA failing reason in #2314 --> [job](https://github.com/PIVX-Project/PIVX/pull/2314/checks?check_run_id=2509761057) Essentially, `BOOST_ASSERT_MSG` only prints static string messages. As we are inputting a dynamic message, the value isn't being printed if the test fails. So, have added a new function `ASSERT_WITH_MSG(cond, msg)` to support dynamic error messages. ACKs for top commit: random-zebra: ACK 8ff6fa2 and merging... (this means another rebase for #2360) Tree-SHA512: a47c8f94a497696a5bbb2b09b01f8dd1711b898a3d363211d12c79fd92b67a4f4d255a2c97ae192e17ccab706a604e16140a18bc7ea3f3539e8fad4559351902
- delete old uint256.h/uint256.cpp files - delete old uint512.h - rename files blob_uint256.h/blob_uint256.cpp --> uint256.h/uint256.cpp - rename class blob_uint256 --> uint256 - add uint160/512 blob implementation inside uint256.* files - move UintToArith/ArithToUint to arith_uint256.cpp
random-zebra
force-pushed
the
202104_uint256
branch
from
7bbbae3 to
722759d
Compare
Author
|
This will have few conflicts with #2352. They are both a pain to rebase / re-review / re-test, so am not sure which one we want to merge first. Pinging @Fuzzbawls |
Collaborator
|
I'm ok with prioritizing this over #2352 and did some initial code review already, will finish my review later today but looking good so far. |
Fuzzbawls
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally out of an old rabbit hole, started with #1395, #1414, and #2092.
As per title, complete the migration:
arith_uint*classes whenever the uint is interpreted as a numberuint*classes child ofbase_blob, and use it everywhere elseblob_uint*temporary class