[Test] Eliminate race condition in mempool_packages test #2285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
previously approved these changes
Apr 1, 2021
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
utACK d93cab6376be59870f98c7c9a9b2b62fb14dec6f 😉
random-zebra
reviewed
Apr 1, 2021
furszy
force-pushed
the
2021_fix_mempool_packages_race
branch
from
d93cab6 to
600dd4d
Compare
|
Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving the intermittent failures in mempool_packages test that happen way too often.
Coming straight from bitcoin#7368.
PD: thanks to my good zebra for finding the cause