[Consensus][Build] v6 Network upgrade - C++14 standard #2269
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 25, 2021
random-zebra
force-pushed
the
202103-dmn-deployment-stubs
branch
from
f7fa655 to
92c3c8d
Compare
furszy
approved these changes
Mar 31, 2021
Author
|
Can we merge this one? |
Fuzzbawls
approved these changes
Apr 6, 2021
Fuzzbawls
added
the
Needs Release Notes
furszy
added a commit
that referenced
this pull request
Apr 13, 2021
c27bbed [Cleanup] functions impl: branch on new line (random-zebra) 8850b3e [Refactoring] Make CEvoDB mutex public (random-zebra) 304fc46 Take memory used by CEvoDB/CDBTransaction into account when flushing (random-zebra) ed0d4f9 Track memory usage in CDBTransaction and CEvoDB (random-zebra) f259774 Implement CDBTransactionIterator (Alexander Block) 51920cb Change CDBTransaction to compare keys by their serialized form (Alexander Block) 7094a60 Support passing CDataStream as key into CDBWrapper/CDBBatch/CDBIterator (Alexander Block) cdd44d4 [Cleanup] Drop unneeded casts (random-zebra) 65b8ddc [DB] Specialize CScopedDBTransaction for evo database (random-zebra) 34a7541 [Refactoring] Properly add explicit specifier where appropriate (random-zebra) 6a36968 Implement 2-stage commit for CEvoDB to avoid inconsistencies (Alexander Block) e6c7efe [Refactoring] Let Commit() return void (random-zebra) fec56b0 [DB] Ensure evoDB consistency by storing best block hash (random-zebra) be85c9a [Refactoring] migrate evoDb to unique pointer (random-zebra) cab50d3 [Tests] Fix functional test suite with new directory 'evodb' (random-zebra) ad7f5d7 [DB][BUG] Add virtual destructor for KeyValueHolder (random-zebra) d6c56d1 Introduce CEvoDB for all evo related things, e.g. DIP3 (Alexander Block) 2496933 Implement CDBTransaction and CScopedDBTransaction (Alexander Block) da6a2c1 [Build] CMake: Introduce evo headers (random-zebra) f3a7cfb [Trivial] Remove unused variable in ProcessNewBlock (random-zebra) Pull request description: Extracted from #2267. This introduces the new database, used for all DMN-related things, and updates the dbWrapper. Builds on top of: - [x] #2269 - [x] #2270 ACKs for top commit: Fuzzbawls: Code ACK c27bbed furszy: Code ACK c27bbed. Tree-SHA512: a93b0c96759b9493659d2e5c69d2fa9d7dbcb260b7f7ec4d2e7db2d1f2a4561f9548bbe4db07272792b5d6dbf33fd8e7c84f04d958781e6d9bb3fb1fdcbf2ea1
random-zebra
removed
the
Needs Release Notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2267.
This includes the network upgrade parameter for
UPGRADE_V6_0(currently disabled on all three networks), and definesSPORK_21_LEGACY_MNS_MAX_HEIGHT, which will be used for the transition to DMN lists (as described, under "deployment", in #2267).This also sets the C++ standard to
14, which will be required by the immer library, and other parts of the code.