[Qt][Feature Request] Add search option to My Addresses list #2250
Conversation
|
This is cool! 💜 |
random-zebra
left a comment
random-zebra
left a comment
There was a problem hiding this comment.
This is indeed pretty cool, and it works great. Thanks @PicklesRcool!
The only nit would be to squash the three commits, that are all editing the same (newly introduced) code.
|
I think this would be good to have. Maybe we can squash-merge it, addressing possible nits in a follow-up PR. |
|
If @PicklesRcool is not around to make the changes, the best path would be to cherry-pick the squashed commit and fixup any change from the review under his authorship in another PR. The ability for maintainers to push to his branch seems to not be active. I still have this one pending to test. Code wise, the increment of the |
…widget (PicklesRcool) 274fb26 Add search option to My Addresses list in receive widget (Volodia) Pull request description: This is an updated version of #2250 : - remove un-needed width increment in receivewidget.ui - squashed the commits down to one - push under @PicklesRcool's authorship ACKs for top commit: furszy: Tested ACK 274fb26 . Tree-SHA512: fe6aa6def3525c8c60b9f425e5e60f223d8cbbca7ee109fab98ba572a0306a2dd9df85d157232668f2549e90045f2996ecbfcf40ab87e31b8736912316727685
|
Squash-merged in #2353 |
4 participants
This PR adds a filter box to the My Addresses list in the Receive section.
Issue: #1635
How it works:
https://user-images.githubusercontent.com/36901185/111183252-603cb500-85b8-11eb-8549-e31a9f18ba70.mp4
The edit box filters the address rows for both the name or the address itself. It also has a maximum input length of 40 characters.